Add bilingual option (show both original text and translated text at the same time) -- for language learners#852
Open
rholop wants to merge 15 commits into
Open
Add bilingual option (show both original text and translated text at the same time) -- for language learners#852rholop wants to merge 15 commits into
rholop wants to merge 15 commits into
Conversation
Add bilingual mode to display original and translated text
Merge pull request #1 from rholop/claude/confident-hopper-gxgyvx
Claude/confident hopper gxgyvx
Add release CI workflow and document dual-subtitles bilingual mode
Fix BilingualFormat: unescape \n in config so it renders as a newline
Fix duplicate using System; directive
…ore RuntimeHooker The PreBuild XCOPY in XUnity.RuntimeHooker.csproj depends on the output of XUnity.RuntimeHooker.Trampolines, but no project reference enforced that build order, causing intermittent MSB3073 failures under msbuild /m.
Remove the fork-specific "About this fork" section and instead introduce bilingual mode as a regular feature in the Introduction, pointing to the existing BilingualMode/BilingualFormat config docs.
Claude/confident hopper gxgyvx
ManlyMarco
requested changes
Jun 15, 2026
ManlyMarco
left a comment
ManlyMarco
left a comment
Collaborator
There was a problem hiding this comment.
Please revert changes unrelated to bilingual mode, e.g. the workflow, build instructions and csproj changes. I think the introduction section change is also unnecessary and should be removed.
The code changes themselves look correct.
There was a problem hiding this comment.
Pull request overview
Adds a bilingual/dual-subtitles mode to the AutoTranslator plugin so language learners can see original + translated text simultaneously, plus updates docs and adds a CI workflow to build release packages.
Changes:
- Introduces
BilingualModeandBilingualFormatconfiguration options (and forces UI resizing when enabled). - Composes and sets bilingual UI text in the core translation flow, and avoids re-processing known bilingual composites.
- Documents bilingual mode + adds “Building from Source” documentation and a GitHub Actions workflow for Release builds/artifacts.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/XUnity.RuntimeHooker/XUnity.RuntimeHooker.csproj |
Adds a project reference to trampolines (non-output reference) to support build/link requirements. |
src/XUnity.AutoTranslator.Plugin.Core/Configuration/Settings.cs |
Adds config surface for bilingual mode/format and forces UI resizing when enabled. |
src/XUnity.AutoTranslator.Plugin.Core/AutoTranslationPlugin.cs |
Implements bilingual string composition + composite detection in translation paths and toggle flow. |
README.md |
Documents bilingual mode and adds source build/CI packaging documentation. |
.github/workflows/build-release.yml |
Adds Windows CI to build Release and publish dist/*.zip artifacts and tagged releases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.