WIP, Move to sdk/v3 and go-client/v4#22
Open
bzz wants to merge 3 commits intobblfsh:masterfrom
Open
Conversation
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
dennwc
reviewed
Jun 4, 2019
Member
dennwc
left a comment
dennwc
left a comment
There was a problem hiding this comment.
This part of the change looks good! Not approving yet, since there are few more points in the TODO list.
| "github.com/bblfsh/sdk/v3/uast/nodes" | ||
| ) | ||
|
|
||
| // Tokenizer sub-command outputs every token to STDOUT. |
Member
There was a problem hiding this comment.
I imagine this won't work as one may expect. Tokens are missing for some structures.
Co-Authored-By: Denys Smirnov <denis.smirnov.91@gmail.com>
Co-Authored-By: Denys Smirnov <denis.smirnov.91@gmail.com>
Contributor
Author
|
As much as I would love to finish this work that have taught me a lot - I do not think I'll have time for it in next few weeks, so removing myself from assignment for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress
it, _ := tools.Filter(n, "./*")only visits the root node)This change is