Add binary conversion calls and rspec tests

modules/encoders/riscv32le/byte_xori.rb

@@ -34,7 +34,7 @@ def initialize
   # the buffer being encoded.
   #
   def decoder_stub(state)
-    if state.badchars.to_s.include?("\x00")
+    if state.badchars.to_s.include?("\x00".b)
       raise EncodingError, 'The RISC-V decoder stub inherently contains null bytes (auipc, ecall)'
     end
 

modules/encoders/riscv32le/longxor.rb

@@ -32,7 +32,7 @@ def initialize
   # the buffer being encoded.
   #
   def decoder_stub(state)
-    if state.badchars.to_s.include?("\x00")
+    if state.badchars.to_s.include?("\x00".b)
       raise EncodingError, 'The RISC-V decoder stub inherently contains null bytes (auipc, ecall)'
     end
 
@@ -84,7 +84,7 @@ def decoder_stub(state)
     ].pack('V*')
 
     state.decoder_key_offset = decoder.length
-    decoder + "\x00\x00\x00\x00"
+    decoder + "\x00\x00\x00\x00".b
   end
 
   private

modules/encoders/riscv32le/longxor_feedback.rb

@@ -35,7 +35,7 @@ def initialize
   # the buffer being encoded.
   #
   def decoder_stub(state)
-    if state.badchars.to_s.include?("\x00")
+    if state.badchars.to_s.include?("\x00".b)
       raise EncodingError, 'The RISC-V decoder stub inherently contains null bytes (auipc, ecall)'
     end
 
@@ -89,7 +89,7 @@ def decoder_stub(state)
     ].pack('V*')
 
     state.decoder_key_offset = decoder.length
-    decoder + "\x00\x00\x00\x00"
+    decoder + "\x00\x00\x00\x00".b
   end
 
   #
@@ -120,7 +120,7 @@ def find_key_verify(buf, key_bytes, badchars)
     feedback = key_bytes_to_integer(key_bytes)
 
     buf.bytes.each_slice(4) do |bytes|
-      block = bytes.pack('C*').ljust(4, "\x00")
+      block = bytes.pack('C*').ljust(4, "\x00".b)
       encoded_val = block.unpack1('V') ^ feedback
       return false unless has_badchars?([encoded_val].pack('V'), badchars).nil?
 

modules/encoders/riscv32le/longxor_tag.rb

@@ -38,7 +38,7 @@ def initialize
   # the buffer being encoded.
   #
   def decoder_stub(state)
-    if state.badchars.to_s.include?("\x00")
+    if state.badchars.to_s.include?("\x00".b)
       raise EncodingError, 'The RISC-V decoder stub inherently contains null bytes (auipc, ecall)'
     end
 
@@ -92,7 +92,7 @@ def decoder_stub(state)
     ].pack('V*')
 
     state.decoder_key_offset = decoder.length
-    decoder + "\x00\x00\x00\x00"
+    decoder + "\x00\x00\x00\x00".b
   end
 
   #

modules/encoders/riscv64le/byte_xori.rb

@@ -34,7 +34,7 @@ def initialize
   # the buffer being encoded.
   #
   def decoder_stub(state)
-    if state.badchars.to_s.include?("\x00")
+    if state.badchars.to_s.include?("\x00".b)
       raise EncodingError, 'The RISC-V decoder stub inherently contains null bytes (auipc, ecall)'
     end
 

modules/encoders/riscv64le/longxor.rb

@@ -32,7 +32,7 @@ def initialize
   # the buffer being encoded.
   #
   def decoder_stub(state)
-    if state.badchars.to_s.include?("\x00")
+    if state.badchars.to_s.include?("\x00".b)
       raise EncodingError, 'The RISC-V decoder stub inherently contains null bytes (auipc, ecall)'
     end
 
@@ -84,7 +84,7 @@ def decoder_stub(state)
     ].pack('V*')
 
     state.decoder_key_offset = decoder.length
-    decoder + "\x00\x00\x00\x00"
+    decoder + "\x00\x00\x00\x00".b
   end
 
   private

modules/encoders/riscv64le/longxor_feedback.rb

@@ -35,7 +35,7 @@ def initialize
   # the buffer being encoded.
   #
   def decoder_stub(state)
-    if state.badchars.to_s.include?("\x00")
+    if state.badchars.to_s.include?("\x00".b)
       raise EncodingError, 'The RISC-V decoder stub inherently contains null bytes (auipc, ecall)'
     end
 
@@ -89,7 +89,7 @@ def decoder_stub(state)
     ].pack('V*')
 
     state.decoder_key_offset = decoder.length
-    decoder + "\x00\x00\x00\x00"
+    decoder + "\x00\x00\x00\x00".b
   end
 
   #
@@ -120,7 +120,7 @@ def find_key_verify(buf, key_bytes, badchars)
     feedback = key_bytes_to_integer(key_bytes)
 
     buf.bytes.each_slice(4) do |bytes|
-      block = bytes.pack('C*').ljust(4, "\x00")
+      block = bytes.pack('C*').ljust(4, "\x00".b)
       encoded_val = block.unpack1('V') ^ feedback
       return false unless has_badchars?([encoded_val].pack('V'), badchars).nil?
 

modules/encoders/riscv64le/longxor_tag.rb

@@ -38,7 +38,7 @@ def initialize
   # the buffer being encoded.
   #
   def decoder_stub(state)
-    if state.badchars.to_s.include?("\x00")
+    if state.badchars.to_s.include?("\x00".b)
       raise EncodingError, 'The RISC-V decoder stub inherently contains null bytes (auipc, ecall)'
     end
 
@@ -92,7 +92,7 @@ def decoder_stub(state)
     ].pack('V*')
 
     state.decoder_key_offset = decoder.length
-    decoder + "\x00\x00\x00\x00"
+    decoder + "\x00\x00\x00\x00".b
   end
 
   #

spec/modules/encoders/riscv32le/byte_xori_spec.rb

@@ -0,0 +1,6 @@
+require 'spec_helper'
+require_relative '../riscv_xor_encoder_examples'
+
+RSpec.describe 'modules/encoders/riscv32le/byte_xori' do
+  it_behaves_like 'riscv byte_xori encoder', 'riscv32le/byte_xori'
+end

spec/modules/encoders/riscv32le/longxor_feedback_spec.rb

@@ -0,0 +1,6 @@
+require 'spec_helper'
+require_relative '../riscv_xor_encoder_examples'
+
+RSpec.describe 'modules/encoders/riscv32le/longxor_feedback' do
+  it_behaves_like 'riscv longxor_feedback encoder', 'riscv32le/longxor_feedback'
+end

spec/modules/encoders/riscv32le/longxor_spec.rb

@@ -0,0 +1,6 @@
+require 'spec_helper'
+require_relative '../riscv_xor_encoder_examples'
+
+RSpec.describe 'modules/encoders/riscv32le/longxor' do
+  it_behaves_like 'riscv longxor encoder', 'riscv32le/longxor'
+end

spec/modules/encoders/riscv32le/longxor_tag_spec.rb

@@ -0,0 +1,6 @@
+require 'spec_helper'
+require_relative '../riscv_xor_encoder_examples'
+
+RSpec.describe 'modules/encoders/riscv32le/longxor_tag' do
+  it_behaves_like 'riscv longxor_tag encoder', 'riscv32le/longxor_tag'
+end

spec/modules/encoders/riscv64le/byte_xori_spec.rb

@@ -0,0 +1,6 @@
+require 'spec_helper'
+require_relative '../riscv_xor_encoder_examples'
+
+RSpec.describe 'modules/encoders/riscv64le/byte_xori' do
+  it_behaves_like 'riscv byte_xori encoder', 'riscv64le/byte_xori'
+end

spec/modules/encoders/riscv64le/longxor_feedback_spec.rb

@@ -0,0 +1,6 @@
+require 'spec_helper'
+require_relative '../riscv_xor_encoder_examples'
+
+RSpec.describe 'modules/encoders/riscv64le/longxor_feedback' do
+  it_behaves_like 'riscv longxor_feedback encoder', 'riscv64le/longxor_feedback'
+end

spec/modules/encoders/riscv64le/longxor_spec.rb

@@ -0,0 +1,6 @@
+require 'spec_helper'
+require_relative '../riscv_xor_encoder_examples'
+
+RSpec.describe 'modules/encoders/riscv64le/longxor' do
+  it_behaves_like 'riscv longxor encoder', 'riscv64le/longxor'
+end

spec/modules/encoders/riscv64le/longxor_tag_spec.rb

@@ -0,0 +1,6 @@
+require 'spec_helper'
+require_relative '../riscv_xor_encoder_examples'
+
+RSpec.describe 'modules/encoders/riscv64le/longxor_tag' do
+  it_behaves_like 'riscv longxor_tag encoder', 'riscv64le/longxor_tag'
+end