토큰 정비 및 popover, segment-control, skip-link 추가#10
Merged
Conversation
Owner
berrypjh
commented
May 18, 2026
berrypjh
commented
- 디자인 토큰: web 빌드용 ds/web/rem transform 추가(dimension/fontSize/lineHeight를 px→rem).
- react-ui: 신규 컴포넌트 3종 추가 (popover, segment-control, skip-link)
- sd.ts에 dimension/fontSize/lineHeight를 px→rem으로 변환하는 ds/web/rem transform 등록 (WEB_TRANSFORMS에서 ts/size/px 제외) - spacing 토큰 리네이밍 및 scale 축소 (xxxsm→2xs, xxsm→xs, xsm→sm, sml→md, xlg→xl, xxl→2xl, 5xl→4xl 등) - color에 icon 카테고리 추가, stroke/background.disable·placeholder 추가, dark/light의 focusRipple·disable 값 조정
- 신규 컴포넌트: Popover(compound + context 기반 제어/비제어), SegmentControl(제네릭 토글 그룹), SkipLink(skip-to-content 앵커) - 기존 SCSS의 spacing 토큰을 design-tokens 리네이밍에 맞춰 정렬하고 line-height의 calc(* 1px) 래핑 제거 - 스토리의 a11y 우회(disable) 제거 및 위반 수정, preview.ts에 mobile/tablet/desktop viewport 프리셋 추가
- light는 ne400(2.9:1), dark는 ne600(2.1:1)으로 회귀되어 axe color-contrast 위반 발생 - 둘 다 ne500으로 되돌려 light 5.7:1, dark 6.0:1로 AA 통과 (e0b2360 fix 의도 복원)
…es 색상) - Select: aria-label/aria-labelledby를 root div 대신 inner combobox 버튼으로 forward (aria-prohibited-attr 해소) - Fab secondary 배경을 se500→se700으로 변경해 contrastText 대비 5.8:1로 AA 통과 - FormControl A11y 스토리에서 div 래퍼로 흐르던 중복 aria-required 제거, IconButton/FormHelperText/InputLabel/Select 스토리의 하드코딩 #888/red를 #666/#c00로 교정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.