fix: add workerd condition for password export#17
Merged
bytaesu merged 2 commits intoMay 27, 2026
Conversation
|
need this too -- thanks!! |
Contributor
Author
|
@ping-maxwell can u review this? |
Member
|
Hi @GautamBytes, I removed the test file since it doesn't provide much value for testing here! |
bytaesu
pushed a commit
that referenced
this pull request
May 27, 2026
Member
|
Hey @GautamBytes, I merged it normally, so I redid it as a squash merge to preserve your contribution history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workerdcondition for the./passwordexport.nodejs_compatis enabled.Why
Wrangler uses the
workerdconditional export key when bundling Cloudflare Workers. Without aworkerdcondition,@better-auth/utils/passwordfalls through to the default ESM export and bundles the pure JS fallback instead ofpassword.node.mjs, even when Workers has Node compatibility enabled.Related to better-auth/better-auth#9649.