feat(BBBHint): allow uncontrolled open/close state & add hideCloseButton prop - #66
Open
Arthurk12 wants to merge 2 commits into
Open
feat(BBBHint): allow uncontrolled open/close state & add hideCloseButton prop#66Arthurk12 wants to merge 2 commits into
hideCloseButton prop#66Arthurk12 wants to merge 2 commits into
Conversation
Adds an optional `open` prop so BBBHint can manage its own visibility and close itself when the close button is clicked, removing the need for external useState boilerplate in simple cases. Passing `open` switches to the existing controlled behavior, where the parent decides visibility via `onRequestClose`. Closes bigbluebutton#29
Adds a `hideCloseButton` prop to hide the close (X) button for hints that shouldn't be manually dismissed, e.g. ones dismissed via another UI element or tooltip-style hints with no explicit dismiss action. The close button no longer depends on `title` being set, so label-only hints can now show one too unless hidden. Closes bigbluebutton#30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an optional
openprop so BBBHint can manage its own visibility and close itself when the close button is clicked, removing the need for external useState boilerplate in simple cases. Passingopenswitches to the existing controlled behavior, where the parent decides visibility viaonRequestClose.Adds a
hideCloseButtonprop to hide the close (X) button for hints that shouldn't be manually dismissed, e.g. ones dismissed via another UI element or tooltip-style hints with no explicit dismiss action. The close button no longer depends ontitlebeing set, solabel-only hints can now show one too unless hidden.
Closes Issue(s)
Closes #29
Closes #30