Feature/game controller hsl cleanup#955
Conversation
Flova
left a comment
There was a problem hiding this comment.
This changes a lot of things and we need to also adapt all downstream subscriptions of e.g. game state. Otherwise the behavior and localization will crash.
|
This PR works, in simulation, as far as I can test it. (which means only a single robot because the game controller software doesn't work otherwise) |
|
Then I am missing something. Because e.g. the penalty field has a new type and has no downstream adaptions. Same with secs remaining. I am pretty sure all of these are referenced in localization, behavior. |
after properly setting up a PlayerStateResponse in bit-bots/game_controller_hsl#1 This makes the architecture much cleaner as we do not have dependencies to `game_controller_hsl` in multiple components, which could also function without any game controller.
based on `IS_ROBOT` environment variable
|
The changes to the GameState are as follows:
|
cb89865 to
6a3c87d
Compare
…c/lib/game_controller_hsl subrepo: subdir: "src/lib/game_controller_hsl" merged: "7c48f279e" upstream: origin: "git@github.com:bit-bots/game_controller_hsl.git" branch: "feature/abstract-for-open-source" commit: "7c48f279e" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "ea10886"
6a3c87d to
e2a72b8
Compare
jgueldenstein
left a comment
There was a problem hiding this comment.
tested in sim with multiple robots, and on a single real robot
tested in sim and real world, works,
My bad. I missread the diff and thought penalized was removed. Sorry |
Summary
Make architecture cleaner, by not having different components rely on
game_controller_hsl.Proposed changes
based on
IS_ROBOTenvironment variableafter properly setting up a PlayerStateResponse in
bit-bots/game_controller_hsl#1
This makes the architecture much cleaner as we do not have dependencies
to
game_controller_hslin multiple components, which could alsofunction without any game controller.
Related issues
Checklist
pixi run build