Skip to content

Use OTel secrets in CD GitHub actions (#12573)#12575

Merged
yasmoradi merged 4 commits into
bitfoundation:developfrom
yasmoradi:12573
Jul 5, 2026
Merged

Use OTel secrets in CD GitHub actions (#12573)#12575
yasmoradi merged 4 commits into
bitfoundation:developfrom
yasmoradi:12573

Conversation

@yasmoradi

@yasmoradi yasmoradi commented Jul 4, 2026

Copy link
Copy Markdown
Member

closes #12573

Summary by CodeRabbit

  • Chores
    • Updated Windows hybrid build/deployment workflows to include additional runtime configuration values for application observability.
    • These changes apply across the sample app release pipelines and do not alter app features or publishing steps.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Three CI/CD workflow files (admin-sample, sales-module-demo, todo-sample) each add two environment variables—OTEL_EXPORTER_OTLP_ENDPOINT and OTEL_EXPORTER_OTLP_HEADERS—sourced from GitHub secrets to the Windows hybrid build job's appsettings.json variable substitution step.

Changes

OTel Environment Variable Additions

Layer / File(s) Summary
Add OTel exporter secrets to CD workflows
.github/workflows/admin-sample.cd.yml, .github/workflows/sales-module-demo.cd.yml, .github/workflows/todo-sample.cd.yml
Each workflow's Windows hybrid build job now sources OTEL_EXPORTER_OTLP_ENDPOINT and OTEL_EXPORTER_OTLP_HEADERS from secrets into the appsettings.json substitution step.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

Three workflows hop in tidy rows,
Each gains a secret, and off it goes—
OTLP whispers where it's sent,
Endpoint and headers, safely lent. 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The workflow updates satisfy #12573 by wiring OTel secrets into the demo apps' CD GitHub Actions.
Out of Scope Changes check ✅ Passed The changes stay within scope by only adding OTel secret env vars to the targeted CD workflow steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: wiring OTel secrets into CD GitHub Actions workflows.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yasmoradi yasmoradi changed the title Read OTel secrets in demo apps CD GitHub actions (#12573) Read OTel secrets in CD GitHub actions (#12573) Jul 5, 2026
@yasmoradi yasmoradi changed the title Read OTel secrets in CD GitHub actions (#12573) Use OTel secrets in CD GitHub actions (#12573) Jul 5, 2026
@yasmoradi yasmoradi merged commit 7281700 into bitfoundation:develop Jul 5, 2026
3 checks passed
@yasmoradi yasmoradi deleted the 12573 branch July 5, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CD GitHub Actions must use OTel secrets

1 participant