Skip to content

Remove Json.NET reference from bit BlazorUI as it's no longer needed by Chart (#12588)#12589

Merged
yasmoradi merged 1 commit into
bitfoundation:developfrom
yasmoradi:12588
Jul 5, 2026
Merged

Remove Json.NET reference from bit BlazorUI as it's no longer needed by Chart (#12588)#12589
yasmoradi merged 1 commit into
bitfoundation:developfrom
yasmoradi:12588

Conversation

@yasmoradi

@yasmoradi yasmoradi commented Jul 5, 2026

Copy link
Copy Markdown
Member

closes #12588

Summary by CodeRabbit

  • Chores
    • Removed an unused JSON package dependency from several UI projects.
    • Simplified the web client build setup by dropping an unused lazy-load entry.
    • Cleaned up a file header formatting issue in the Windows client project.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 85d44173-0ee4-413f-aab0-89406fc59447

📥 Commits

Reviewing files that changed from the base of the PR and between 6cebee9 and 6aa9b0f.

📒 Files selected for processing (4)
  • src/BlazorUI/Bit.BlazorUI.Extras/Bit.BlazorUI.Extras.csproj
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj
💤 Files with no reviewable changes (3)
  • src/BlazorUI/Bit.BlazorUI.Extras/Bit.BlazorUI.Extras.csproj
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj

Walkthrough

Removes the Newtonsoft.Json NuGet package reference from four BlazorUI project files (Extras, Demo Maui, Demo Web, Demo Windows), removes an associated BlazorWebAssemblyLazyLoad entry referencing Newtonsoft.Json.wasm in the Web project, and strips a BOM from the Windows csproj header.

Changes

Newtonsoft.Json Dependency Removal

Layer / File(s) Summary
Remove package references and lazy-load config
src/BlazorUI/Bit.BlazorUI.Extras/Bit.BlazorUI.Extras.csproj, src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj, src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj, src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj
Removes the Newtonsoft.Json PackageReference from each project, deletes the BlazorWebAssemblyLazyLoad ItemGroup entry referencing Newtonsoft.Json.wasm in the Web project, and removes a leading BOM character from the Windows csproj header.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Hop, hop, out goes the JSON weight,
No more Newtonsoft to carry the freight 🐇
Four little csproj files trimmed so neat,
A BOM swept away, the build feels sleek,
Onward we bound, light on our feet!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The Windows csproj also includes an unrelated BOM/header change beyond removing Json.NET references. Split out or revert the BOM/header-only edit so the PR stays focused on removing Json.NET references.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing Json.NET references from BlazorUI because Chart no longer needs it.
Linked Issues check ✅ Passed The PR removes Newtonsoft.Json references from the BlazorUI demo client projects, matching the issue to stop Chart-related Json.NET usage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yasmoradi yasmoradi merged commit 2155163 into bitfoundation:develop Jul 5, 2026
3 checks passed
@yasmoradi yasmoradi deleted the 12588 branch July 5, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bit BlazorUI must stop referencing Json.NET as it's no longer needed by Chart component

1 participant