use importlib machinery to check for habana plugin#1910
Merged
matthewdouglas merged 3 commits intoApr 3, 2026
Conversation
Not all environments have pip, and even fewer have grep (e.g. Windows platforms), and the shell command is relatively costly for larger environments. Instead, use the stdlib infrastructure with `importlib` to identify the version of `habana-torch-plugin` if it is installed.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
matthewdouglas
previously requested changes
Apr 3, 2026
matthewdouglas
left a comment
matthewdouglas
left a comment
Member
There was a problem hiding this comment.
LGTM, except for one minor nit. Thanks!
Contributor
Author
|
Thanks for the quick turnaround on the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all environments have pip, and even fewer have grep (e.g. Windows platforms), and the shell command is relatively costly for larger environments. Instead, use the stdlib infrastructure with
importlibto identify the version ofhabana-torch-pluginif it is installed.