Skip to content

Improve Windows guidance for CUDA override environment variables#1970

Closed
wunianze666-netizen wants to merge 1 commit into
bitsandbytes-foundation:mainfrom
wunianze666-netizen:fix/windows-env-override-guidance
Closed

Improve Windows guidance for CUDA override environment variables#1970
wunianze666-netizen wants to merge 1 commit into
bitsandbytes-foundation:mainfrom
wunianze666-netizen:fix/windows-env-override-guidance

Conversation

@wunianze666-netizen

Copy link
Copy Markdown

Summary

  • make cextension.py generate platform-aware set/clear instructions for override environment variables
  • replace Linux-only export/unset guidance in CUDA/ROCm override errors and warnings with Windows-specific instructions when running on Windows
  • add regression tests for the new instruction helpers

Why

The current override guidance is shown to Windows users as well, but it only suggests Unix shell commands. This change keeps the existing Unix guidance while making the same messages actionable on Windows.

Validation

  • ran a local stub-based regression script to verify the Windows instruction strings and a Windows-targeted CUDA override error path
  • ran python -m py_compile bitsandbytes/cextension.py tests/test_cuda_setup_evaluator.py

@matthewdouglas matthewdouglas added Duplicate This issue or pull request already exists Documentation Improvements or additions to documentation labels Jun 10, 2026
@matthewdouglas

Copy link
Copy Markdown
Member

Thanks, but this looks like a duplicate of #1957.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants