Improve Windows guidance for CUDA override environment variables#1970
Closed
wunianze666-netizen wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks, but this looks like a duplicate of #1957. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cextension.pygenerate platform-aware set/clear instructions for override environment variablesexport/unsetguidance in CUDA/ROCm override errors and warnings with Windows-specific instructions when running on WindowsWhy
The current override guidance is shown to Windows users as well, but it only suggests Unix shell commands. This change keeps the existing Unix guidance while making the same messages actionable on Windows.
Validation
python -m py_compile bitsandbytes/cextension.py tests/test_cuda_setup_evaluator.py