Skip to content

PM-37911: Feat: Update Organization model#6960

Open
david-livefront wants to merge 1 commit into
mainfrom
PM-37911-organization-network-model
Open

PM-37911: Feat: Update Organization model#6960
david-livefront wants to merge 1 commit into
mainfrom
PM-37911-organization-network-model

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

@david-livefront david-livefront commented May 21, 2026

🎟️ Tracking

PM-37911

📔 Objective

This PR updates the Organization network model to include significantly more data. This data is required for use with the SDK (coming soon).

@david-livefront david-livefront requested a review from a team as a code owner May 21, 2026 19:07
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels May 21, 2026
@david-livefront david-livefront force-pushed the PM-37911-organization-network-model branch from aee1dd1 to 2f37379 Compare May 21, 2026 19:10
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.36%. Comparing base (fb955e9) to head (e76eade).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6960      +/-   ##
==========================================
- Coverage   86.47%   86.36%   -0.12%     
==========================================
  Files         872      875       +3     
  Lines       63666    63748      +82     
  Branches     9234     9234              
==========================================
  Hits        55055    55055              
- Misses       5436     5518      +82     
  Partials     3175     3175              
Flag Coverage Δ
app-data 17.23% <100.00%> (ø)
app-ui-auth-tools 19.02% <0.00%> (ø)
app-ui-platform 16.49% <0.00%> (ø)
app-ui-vault 27.81% <0.00%> (ø)
authenticator 6.21% <0.00%> (-0.01%) ⬇️
lib-core-network-bridge 4.08% <0.00%> (-0.01%) ⬇️
lib-data-ui 1.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-livefront david-livefront force-pushed the PM-37911-organization-network-model branch 4 times, most recently from 0d72f25 to 0851a91 Compare May 21, 2026 21:09
@SaintPatrck SaintPatrck added the ai-review-vnext Request a Claude code review using the vNext workflow label May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR extends SyncResponseJson.Profile.Organization with ~50 new fields (and Permissions with 10 new fields) to surface the full Organization payload from the server, introduces three new enum models (MemberDecryptionType, ProductTierType, ProviderType) using the existing BaseEnumeratedIntSerializer pattern, and switches numeric capacity fields (seats, maxCollections, maxStorageGb) from Int? to UInt? consistent with other models in network/. The legacy network field shouldUseKeyConnector (JSON keyConnectorEnabled) was renamed to isKeyConnectorEnabled, with a separate new field shouldUseKeyConnector mapped from the new JSON property useKeyConnector; the Organization domain mapper continues to derive shouldUseKeyConnector from isKeyConnectorEnabled, preserving existing behavior pending SDK integration. New defaults plus the shared Json configuration (explicitNulls = false, coerceInputValues = true in CoreModule) keep deserialization safe against missing or null server values, and SyncServiceTest plus the testFixture utilities were updated to exercise every new field.

Code Review Details

No findings.

SaintPatrck
SaintPatrck previously approved these changes May 22, 2026
@david-livefront david-livefront force-pushed the PM-37911-organization-network-model branch from b03ff62 to e76eade Compare May 28, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants