Skip to content

Chore: Remove the Manager type from OrganizationType#6984

Merged
david-livefront merged 1 commit into
mainfrom
remove-manager-org-user-type
May 28, 2026
Merged

Chore: Remove the Manager type from OrganizationType#6984
david-livefront merged 1 commit into
mainfrom
remove-manager-org-user-type

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR removes the MANAGER type from the OrganizationType enum. The value is never used and the server side migrated all accounts several years ago.

@david-livefront david-livefront requested a review from a team as a code owner May 28, 2026 17:17
@david-livefront david-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label May 28, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:tech-debt Change Type - Tech debt labels May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR removes the MANAGER value from the OrganizationType enum along with its mapping to OrganizationUserType.ADMIN in VaultSdkOrganizationExtensions, and updates the corresponding test fixture. The change is consistent with the PR description noting the server-side migration completed several years ago. A repository-wide search confirms no remaining references to OrganizationType.MANAGER in production or test code.

Code Review Details

No issues found.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.37%. Comparing base (0f4b3fb) to head (98c5733).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6984      +/-   ##
==========================================
- Coverage   86.48%   86.37%   -0.12%     
==========================================
  Files         872      875       +3     
  Lines       63654    63735      +81     
  Branches     9225     9225              
==========================================
- Hits        55052    55051       -1     
- Misses       5435     5517      +82     
  Partials     3167     3167              
Flag Coverage Δ
app-data 17.23% <ø> (-0.01%) ⬇️
app-ui-auth-tools 19.02% <ø> (+<0.01%) ⬆️
app-ui-platform 16.49% <ø> (+<0.01%) ⬆️
app-ui-vault 27.81% <ø> (+<0.01%) ⬆️
authenticator 6.21% <ø> (-0.06%) ⬇️
lib-core-network-bridge 4.08% <ø> (-0.01%) ⬇️
lib-data-ui 1.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-livefront
Copy link
Copy Markdown
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue May 28, 2026
Merged via the queue into main with commit a872db1 May 28, 2026
24 of 29 checks passed
@david-livefront david-livefront deleted the remove-manager-org-user-type branch May 28, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants