Skip to content

[PM-36970] fix: Correct Update Payment status description#6988

Open
SaintPatrck wants to merge 1 commit into
mainfrom
premium-upgrade/PM-36970_copy-update
Open

[PM-36970] fix: Correct Update Payment status description#6988
SaintPatrck wants to merge 1 commit into
mainfrom
premium-upgrade/PM-36970_copy-update

Conversation

@SaintPatrck
Copy link
Copy Markdown
Contributor

@SaintPatrck SaintPatrck commented May 28, 2026

🎟️ Tracking

PM-36970

📔 Objective

Correct copy for the "Update payment" subscription status to match Figma. Use "...payment method..." instead of "...payment..."

📸 Screenshots

Before (Preview) After (Preview)

@SaintPatrck SaintPatrck added the ai-review-vnext Request a Claude code review using the vNext workflow label May 28, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:bug Change Type - Bug labels May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a single-string copy correction in ui/src/main/res/values/strings.xml for subscription_update_payment_description, inserting "method" after "payment" to align with Figma. The <annotation arg="0">%1$s</annotation> format argument structure is preserved, so the call site in PlanScreen.kt:740 continues to consume one arg without changes. The companion test in PlanScreenTest.kt:653 was updated to match the new copy. Non-English locale strings will be regenerated via the translation pipeline per project convention.

No findings.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.12%. Comparing base (40604d0) to head (0313fca).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6988      +/-   ##
==========================================
- Coverage   86.79%   86.12%   -0.68%     
==========================================
  Files         902      952      +50     
  Lines       64724    65703     +979     
  Branches     9236     9275      +39     
==========================================
+ Hits        56177    56584     +407     
- Misses       5376     5930     +554     
- Partials     3171     3189      +18     
Flag Coverage Δ
app-data 16.90% <ø> (-0.03%) ⬇️
app-ui-auth-tools 19.21% <ø> (+0.18%) ⬆️
app-ui-platform 16.97% <ø> (+0.12%) ⬆️
app-ui-vault 28.37% <ø> (-0.02%) ⬇️
authenticator 6.26% <ø> (+0.02%) ⬆️
lib-core-network-bridge 4.11% <ø> (+0.02%) ⬆️
lib-data-ui 1.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SaintPatrck SaintPatrck marked this pull request as ready for review May 28, 2026 20:02
@SaintPatrck SaintPatrck requested review from a team and david-livefront as code owners May 28, 2026 20:02
@SaintPatrck SaintPatrck added this pull request to the merge queue May 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants