Skip to content

[PM-38263] fix: Reference invoices in past due subscription description#6994

Merged
SaintPatrck merged 1 commit into
mainfrom
premium-upgrade/PM-38263_past-due-invoices-copy
May 29, 2026
Merged

[PM-38263] fix: Reference invoices in past due subscription description#6994
SaintPatrck merged 1 commit into
mainfrom
premium-upgrade/PM-38263_past-due-invoices-copy

Conversation

@SaintPatrck
Copy link
Copy Markdown
Contributor

@SaintPatrck SaintPatrck commented May 29, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-38263

📔 Objective

The past due grace-period description instructed users to resolve the past due "amount," but a subscription can carry multiple outstanding invoices. Both iOS and the Figma design reference "invoices," so this corrects the Android copy to match the intended, accurate wording.

Affects the subscription_past_due_description plurals resource (both one and other forms); the coupled PlanScreenTest assertion is updated in lockstep.

📸 Screenshots

Figma

Before After

The past due grace-period description told users to resolve the past due
"amount," but a subscription can have multiple outstanding invoices. iOS
and the Figma design both reference "invoices," so this aligns Android with
the intended, accurate copy.
@SaintPatrck SaintPatrck added the ai-review-vnext Request a Claude code review using the vNext workflow label May 29, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:bug Change Type - Bug labels May 29, 2026
@SaintPatrck SaintPatrck marked this pull request as ready for review May 29, 2026 14:46
@SaintPatrck SaintPatrck requested review from a team and david-livefront as code owners May 29, 2026 14:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR corrects the past due grace-period copy from "amount" to "invoices" in the subscription_past_due_description plurals resource, aligning the Android wording with iOS and the Figma design. Both one and other plural forms are updated consistently, and the coupled PlanScreenTest assertion is updated in lockstep. The change preserves all <annotation> tags, bold emphasis spans, and positional argument indices (%1$d, %2$s).

Code Review Details

No findings.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.90%. Comparing base (b57fb9c) to head (6a03224).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6994      +/-   ##
==========================================
- Coverage   86.26%   85.90%   -0.37%     
==========================================
  Files        1008     1004       -4     
  Lines       66332    66310      -22     
  Branches     9308     9304       -4     
==========================================
- Hits        57221    56962     -259     
- Misses       5902     6150     +248     
+ Partials     3209     3198      -11     
Flag Coverage Δ
app-data 17.14% <ø> (-0.39%) ⬇️
app-ui-auth-tools 19.32% <ø> (ø)
app-ui-platform 16.97% <ø> (-0.06%) ⬇️
app-ui-vault 28.38% <ø> (+0.07%) ⬆️
authenticator 6.25% <ø> (+0.04%) ⬆️
lib-core-network-bridge 4.11% <ø> (+0.02%) ⬆️
lib-data-ui 1.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SaintPatrck SaintPatrck added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit 09f0f5b May 29, 2026
28 of 33 checks passed
@SaintPatrck SaintPatrck deleted the premium-upgrade/PM-38263_past-due-invoices-copy branch May 29, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants