[PM-38986] [BEEEP] Update DC docs#817
Conversation
Deploying contributing-docs with
|
| Latest commit: |
af968ee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b7a01e91.contributing-docs.pages.dev |
| Branch Preview URL: | https://beeep-update-dc-docs.contributing-docs.pages.dev |
🤖 Bitwarden Claude Code ReviewOverall Assessment: REQUEST CHANGES Reviewed documentation updates for the Directory Connector after the recent modernization. Changes cover the new repository layout, Rust native module build step, Node.js version bump, and trailing-slash cleanup in OpenLDAP path references. The intent is clear, but one procedural step in Code Review Details
|
| ## Requirements | ||
|
|
||
| - [Node.js](https://nodejs.org/) v20 | ||
| - [Node.js](https://nodejs.org/) v25 |
There was a problem hiding this comment.
❓ QUESTION: Is Node.js v25 intentional? The repo-wide tools doc recommends v22 (LTS), and v25 is an odd-numbered non-LTS release.
Details
docs/getting-started/tools/index.md:38 lists the standard as NodeJS v22. Bumping Directory Connector from v20 (LTS) to v25 (non-LTS, current) is a departure from that baseline. If the DC repo's package.json engines field or .nvmrc actually pins v25, this is correct — otherwise this may have been intended as v22 or v24 (the current LTS lines).
There was a problem hiding this comment.
This is intentional. V25 allows us to use node SEA builds. We will upgrade to a LTS version when one is available. V26 was recent released (as of May 5). So we can upgrade and update the docs here at our convenience.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-38986
📔 Objective
Updates documentation re: DC after the recent modernization has concluded.
📸 Screenshots