Polish agent sharing and snapshots#1852
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f40799ea6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wpfleger96
left a comment
wpfleger96
left a comment
There was a problem hiding this comment.
Kenny — the visual direction here is genuinely good. The share dialog, the people picker, and the native attachment card for recipients are all a clear step up, and I'd like to keep the design as-is. But a set of safety behaviors the old send flow deliberately enforced got dropped on the way to the new UI, and a couple of capabilities lost parity, so I'm requesting changes before this lands.
To set scope: renames and reorganizations are all fine — folding Export snapshot into Share, the menu restructure, etc. The asks below are about capability and safety parity, not naming.
Blocking (details inline):
- Memory-bearing shares upload plaintext agent memory with no confirmation step, and the link footer makes an access claim the relay doesn't actually enforce.
handleSend()bypasses the guarded send pipeline entirely (timeout, moderation-DM fail-closed, destination eligibility, double-send guard).- The recipient card now renders sender-controlled text as the agent's identity before any verification, plus a spoofable "Shared by" attribution.
- ~1,800 lines of the old send stack are left in-tree unreachable, while the 17 E2E tests that pinned the old safety contract were deleted.
- Catalog visibility becomes unmanageable zombie state (writer deleted, reader kept).
One capability question, non-blocking if intentional: channel sharing is gone (people→DM only now) — flagged inline.
One scope note for reviewers: this PR doesn't touch team sharing/export at all — team-managed personas gain the new Share item, but it shares a single agent snapshot.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0be6850eae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86df762b01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-menu-share-export
branch
from
86df762 to
89460a4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a56bc114d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b013c095c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
Code pass is clean at ed82a137e: the latest hardening addresses the prior send-concurrency, live destination eligibility, attribution, stale-DM, edit-label, pending-close, memory-confirmation, and clipboard-validation findings. CI is green.
I am withholding approval because the head no longer contains current main and GitHub now reports the PR as conflicting. The overlap includes agent snapshot/message rendering paths changed by #1846. Please rebase/merge current main, resolve the conflicts, and rerun CI; then this is ready for a final approval gate.
3 participants
Summary
Verification
pnpm checkpnpm test(2,828 passed)pnpm run buildScreenshots
Share agent
Invite people, choose the agent and memory scope, or copy a workspace link.
Export agent
Choose memory scope and PNG or JSON before exporting.
Shared agent attachment
Received agents use the native attachment treatment with Download and Add agent actions.