chore(hooks): use Hermit just for pre-push#1888
Draft
brow wants to merge 1 commit into
Draft
Conversation
Co-authored-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co>
Contributor
Author
|
@codex review |
Contributor
Author
|
@builderbot review |
|
To use Codex here, create a Codex account and connect to github. |
brow
changed the title
just for pre-push
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
The repository pre-push commands now invoke
bin/justrather than a barejust, ensuring each recipe runs through Buzz's Hermit-pinned tools.Pre-commit commands are intentionally unchanged and can be handled separately.
Why?
A bare
justcan resolve outside the repository toolchain when Hermit is not already active. The checked-in proxy makes pre-push validation deterministic across developer environments.How is it tested?
bin/lefthook dumpresolves all four pre-push commands tobin/just.bin/lefthook run pre-push --command rust-tests --force --no-ttypassed.git pushpassed all repository pre-push commands: Rust, desktop, desktop Tauri, and mobile.PATH=/usr/bin:/bin:/opt/homebrew/binand no incoming Flutter,bin/just mobile-testpassed all 482 tests; its child process resolved Hermitbin/flutterat Flutter 3.41.7.bin/just --versionresolved the checked-in.just-1.46.0.pkgproxy;bin/rustc --versionandbin/cargo --versionresolved Rust 1.95.0.Before/after images are not applicable because this only changes local hook tool selection and has no user-visible UI.