Skip to content

Fix integration test script false failure#1892

Draft
brow wants to merge 1 commit into
mainfrom
tomb/bot-1316-fix-test-script-false-failure
Draft

Fix integration test script false failure#1892
brow wants to merge 1 commit into
mainfrom
tomb/bot-1316-fix-test-script-false-failure

Conversation

@brow

@brow brow commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

What changed?

  • Remove the nonexistent buzz-auth integration-test invocation that deterministically recorded a false failure.
  • Let the workspace integration step expose real Cargo/test errors instead of suppressing stderr or using an unreachable fallback.
  • Add a focused shell regression test and run it through the existing test-unit CI path.

Why?

run_test_step records failures but returns success, so the prior || ... true fallbacks were unreachable. Since buzz-auth has no integration-test target, every integration run recorded a phantom failure while hiding Cargo's explanation.

How is it tested?

  • ./scripts/run-tests.sh unit passes (5 steps).
  • Focused test-runner regression test passes directly and through just test-runner-script.
  • Hermit-managed pre-push suites pass.
  • Deep dual pre-review completed; its actionable finding to wire the regression test into CI was addressed.

Integration mode now has only the pre-existing, unrelated git-credential-nostr permission assertion failure. Its real diagnostics are visible on stderr, and the summary contains no buzz-auth integration tests failure.

Before / After

Images are impractical for this shell-script change; terminal output serves as the before/after evidence.

Before

exit=1
Failed (2):
  fail buzz-auth integration tests
  fail workspace integration tests

# The buzz-auth error was hidden by 2>/dev/null.
# Direct command:
error: no test target matches pattern `*` in `buzz-auth` package

After

integration_exit=1
Passed (1):
  pass buzz-db tests
Failed (1):
  fail workspace integration tests

thread 'missing_key' panicked ... expected exit 1 for missing key
thread 'bad_keyfile_permissions' panicked ... expected exit 1 for insecure keyfile permissions
[run-tests] workspace integration tests FAILED

# `buzz-auth integration tests` is absent.

Commit hook note

The global secret scanner flagged unchanged localhost development defaults at scripts/run-tests.sh:43 and .github/workflows/ci.yml:427 (postgres://buzz:buzz_dev@localhost:5432/buzz). Both strings already exist on main and match the repository's Docker Compose development configuration. After independent confirmation and explicit authorization in the BOT-1316 Buzz thread, this commit used the scanner's documented one-shot SKIP_SECRET_SCANNING=1 confirmation; every other commit hook remained active and passed. The diff introduces no credential-like strings.

🤖 This PR was authored with an agent (Buzz: BOT-1316 thread).

Co-authored-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co>
@brow

brow commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@brow

brow commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@builderbot review

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant