Fix integration test script false failure#1892
Draft
brow wants to merge 1 commit into
Draft
Conversation
Co-authored-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co>
Contributor
Author
|
@codex review |
Contributor
Author
|
@builderbot review |
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
buzz-authintegration-test invocation that deterministically recorded a false failure.test-unitCI path.Why?
run_test_steprecords failures but returns success, so the prior|| ... truefallbacks were unreachable. Sincebuzz-authhas no integration-test target, every integration run recorded a phantom failure while hiding Cargo's explanation.How is it tested?
./scripts/run-tests.sh unitpasses (5 steps).just test-runner-script.Integration mode now has only the pre-existing, unrelated
git-credential-nostrpermission assertion failure. Its real diagnostics are visible on stderr, and the summary contains nobuzz-auth integration testsfailure.Before / After
Images are impractical for this shell-script change; terminal output serves as the before/after evidence.
Before
After
Commit hook note
The global secret scanner flagged unchanged localhost development defaults at
scripts/run-tests.sh:43and.github/workflows/ci.yml:427(postgres://buzz:buzz_dev@localhost:5432/buzz). Both strings already exist onmainand match the repository's Docker Compose development configuration. After independent confirmation and explicit authorization in the BOT-1316 Buzz thread, this commit used the scanner's documented one-shotSKIP_SECRET_SCANNING=1confirmation; every other commit hook remained active and passed. The diff introduces no credential-like strings.🤖 This PR was authored with an agent (Buzz: BOT-1316 thread).