Skip to content

chore(hooks): scope pre-push tests by path#1895

Draft
brow wants to merge 1 commit into
mainfrom
path-scope-pre-push-tests
Draft

chore(hooks): scope pre-push tests by path#1895
brow wants to merge 1 commit into
mainfrom
path-scope-pre-push-tests

Conversation

@brow

@brow brow commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

What changed?

Path-scope the four repository pre-push test suites to the same Rust, desktop, and mobile filters used by CI. Detection uses a two-endpoint diff against @{push} and fails closed by selecting every suite when the push ref or diff cannot be resolved.

Why?

Unrelated platform suites currently block pushes: Rust-only changes run Flutter tests, while mobile-only changes run Rust and desktop tests. This keeps the local convenience gate focused while CI remains authoritative.

How is it tested?

Focused validation matrix:

Scenario Selected suites
Rust path Rust + both desktop suites
Desktop / desktop-rust path Both desktop suites
Mobile path Mobile suite
Unrelated docs path None
pnpm-lock.yaml Both desktop suites
justfile / scripts/run-tests.sh Rust + both desktop suites
CI workflow / lefthook.yml All four suites
New branch without upstream All four suites (fail-closed sentinel)
Divergent force push Suites matching the replacement commit range
Unchanged push / branch deletion None
Injected diff failure All four suites (fail-closed sentinel)

lefthook validate, Rust tests, desktop tests, and desktop Tauri tests pass. Mobile validation could not run because Flutter is not installed on this workstation (flutter: command not found). Deep Claude pre-review completed; its verified custom-file-source concern was addressed by making every command consume {files}. No screenshots: this hook-only change has no user-visible UI.

🤖 This PR was authored with an agent; the creating Codex session URL was unavailable in the Buzz runtime.

Co-authored-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co>
@brow

brow commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@brow

brow commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@builderbot review

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant