fix(desktop): clean up Remind me later dialog footer and loading state#1898
Merged
Conversation
Move the Set reminder action out of the custom date & time section and into the dialog footer: Cancel now sits on the left and Set reminder on the right of the same row. While the reminder is being created, the Set reminder button shows a spinner in place of its label. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
Render the button label invisibly instead of removing it and overlay a centered spinner, so the Set reminder button no longer collapses to a small square while a reminder is being created. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
wpfleger96
approved these changes
Jul 15, 2026
wesbillman
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sm:justify-between), so the dialog has a single, conventional action row.Loader2spinner on the button and hide the label withinvisibleinstead of removing it — this keeps the button width stable so the footer doesn't shift while the spinner shows.Old:
New (spinner appears in the set reminder while sending instead of the text):
Testing
just ci(fmt, clippy, desktop lint, unit tests) passed on push via pre-push hooks — desktop-test, rust-tests, mobile-test, and desktop-tauri-test all green.🤖 Generated with Claude Code