Polish community profile onboarding UI#2088
Conversation
wesbillman
left a comment
There was a problem hiding this comment.
Let's get the demo stuff clean up here
d6e6ec5 to
7926699
Compare
wesbillman
left a comment
There was a problem hiding this comment.
Requesting changes because this is not a UI-only change and it diverges from the current onboarding contract.
-
Non-UI production behavior is bundled into the PR.
crates/buzz-pair-relay/src/lib.rschanges the relay's production connection-limit implementation and exposes a new constructor;desktop/src/app/App.tsxchanges first-community cancellation/back behavior by clearing communities and returning to Welcome;AnimatedAvatarCapture.tsxnow auto-starts the camera in compact mode. Those are runtime behavior changes, not presentation. Please remove them from this PR (and split any independently needed fixes). -
The profile field is presented as a username but persisted as the display name. In
CommunityOnboardingFlow.tsx, the UI says “Your username” and suggests@yourusername, butsaveProfile()writes that value todisplayName. Current main asks for “First and last name,” matching the profile/display-name model. This would teach a different concept while storing it in the existing display-name field. Please keep the current display-name semantics/copy unless a real username model is being introduced separately.
The branch is also 4 commits behind current main, including recent onboarding/startup work, and overlaps many of the same files. Once the PR is reduced to styling/layout-only changes and aligned with current main, CI should run on that resulting head.
Keep the current onboarding behavior while giving the community profile step a focused avatar and display-name layout with visual E2E coverage. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
061be08 to
aa2495b
Compare
Why
Polish the first-community profile step without changing onboarding behavior or broadening scope.
What
Scope
UI-only: one onboarding component and its E2E assertion. No relay, app-state, navigation, persistence, camera, settings, shared-style, or avatar-editor-internal changes.
Validation