Skip to content

Polish community profile onboarding UI#2088

Merged
cynfria merged 1 commit into
mainfrom
cynthiac/profile-polish
Jul 19, 2026
Merged

Polish community profile onboarding UI#2088
cynfria merged 1 commit into
mainfrom
cynthiac/profile-polish

Conversation

@cynfria

@cynfria cynfria commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Why

Polish the first-community profile step without changing onboarding behavior or broadening scope.

What

  • Present the avatar as the visual focus of the profile step
  • Replace the oversized key-style name row with a standard labeled display-name field
  • Preserve the existing display-name semantics, onboarding lifecycle, navigation, avatar editor, and camera behavior
  • Update the focused E2E visual assertions

Scope

UI-only: one onboarding component and its E2E assertion. No relay, app-state, navigation, persistence, camera, settings, shared-style, or avatar-editor-internal changes.

Validation

  • Desktop build
  • Desktop typecheck and lint
  • Focused onboarding integration tests
  • Full pre-push suite

@cynfria
cynfria marked this pull request as ready for review July 18, 2026 21:56
@cynfria
cynfria requested a review from a team as a code owner July 18, 2026 21:56

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get the demo stuff clean up here

@cynfria
cynfria force-pushed the cynthiac/profile-polish branch from d6e6ec5 to 7926699 Compare July 18, 2026 23:53

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes because this is not a UI-only change and it diverges from the current onboarding contract.

  1. Non-UI production behavior is bundled into the PR. crates/buzz-pair-relay/src/lib.rs changes the relay's production connection-limit implementation and exposes a new constructor; desktop/src/app/App.tsx changes first-community cancellation/back behavior by clearing communities and returning to Welcome; AnimatedAvatarCapture.tsx now auto-starts the camera in compact mode. Those are runtime behavior changes, not presentation. Please remove them from this PR (and split any independently needed fixes).

  2. The profile field is presented as a username but persisted as the display name. In CommunityOnboardingFlow.tsx, the UI says “Your username” and suggests @yourusername, but saveProfile() writes that value to displayName. Current main asks for “First and last name,” matching the profile/display-name model. This would teach a different concept while storing it in the existing display-name field. Please keep the current display-name semantics/copy unless a real username model is being introduced separately.

The branch is also 4 commits behind current main, including recent onboarding/startup work, and overlaps many of the same files. Once the PR is reduced to styling/layout-only changes and aligned with current main, CI should run on that resulting head.

Keep the current onboarding behavior while giving the community profile step
a focused avatar and display-name layout with visual E2E coverage.

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
@wesbillman
wesbillman force-pushed the cynthiac/profile-polish branch from 061be08 to aa2495b Compare July 19, 2026 01:20
@wesbillman wesbillman changed the title Polish onboarding profile flow Polish community profile onboarding UI Jul 19, 2026
@cynfria
cynfria merged commit c81806d into main Jul 19, 2026
25 checks passed
@cynfria
cynfria deleted the cynthiac/profile-polish branch July 19, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants