Auto-refresh Settings device list after enable/disable#111
Merged
HamptonMakes merged 1 commit intoMay 13, 2026
Merged
Conversation
Wraps the per-device list in a turbo-frame and reloads it from the Stimulus controller after subscribe/unsubscribe succeeds, so the new browser appears (or disappears) without a full page refresh. Changes - Extracts the device list into _devices.html.erb wrapped in a <turbo-frame id=web-push-devices>. - Adds GET /web_push/devices that renders just that partial back into the same frame. - web_push_settings_controller.js: new devicesUrl Stimulus value; after enable/disable success, sets the frame's src to refetch. Generated with Amp
HamptonMakes
deleted the
05-13-auto-refresh_device_list_on_settings_after_enable_disable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When you click "Enable on this device" on the Settings page, the buttons update but the Devices receiving notifications list doesn't reflect the new browser until you reload the page. Same on disable.
Hampton hit this end-to-end:
How
_devices.html.erbwrapped in a<turbo-frame id="web-push-devices">.GET /web_push/devicesthat re-renders the partial inside the same frame.web_push_settings_controller.js: newdevicesUrlStimulus value; after enable/disable success, sets the frame'ssrcto refetch.No new dependencies, no broadcasts — Turbo Frame does the work.
Verification
web_push/subscriptions_spec.rbstill green; controller addition is the newdevicesaction and the partial extraction is behavior-preserving on the initial page render).Generated with Amp