Add stress lock contention mode to stress testing#896
Open
markolazic01 wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
Resolved a conflict |
Contributor
Author
|
it seems workflow fail is unrelated to the changes in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stress: add lock-contention mode with XMSS verify skip (#825)
Closes #825
Adds a
ZEAM_STRESS_SKIP_VERIFYenv variable that skips XMSS signature verification (when set to1ortrue) in the gossip-flood worker'sonBlockpath.Solution details
Went with option (a) (described inside #825) due to it having less maintenance surface further on.
Changes
chain.zig: addskipVerify: booltoCachedProcessedBlockInfo, gate theverifySignatures/verifySignaturesParallelcall on it. Defaults tofalse— no production caller sets it.stress.zig: addreadEnvBoolhelper, readZEAM_STRESS_SKIP_VERIFYinStressConfig, thread it throughStressCtxinto the gossip-flood worker'sonBlockcall.build.zig: addstress-locks-quickbuild step (30s, skip verify), wired intozig build test.Results
Run with 60s and 6 gossip threads
Gossip-flood throughput drops despite less per-iteration work, confirming lock contention is now the bottleneck rather than XMSS verify. Total system lock traffic nearly doubles.
Safety
skipVerifydefaults tofalseinCachedProcessedBlockInfoand is only set by the stress harness. Pre-import still verifies signatures to build trusted chain state.