Conversation
So that we can use more const fn and const generics features.
This compile time environment variable exists for testing only. Previously it would only work with one feature name, now it takes a comma-separated list that's parsed at compile time. This is useful because the KernelFmaAvx2 kernel needs both features fma and avx2 to be enabled, so it's tested by something like this: MMTEST_FEATURE=avx,fma,avx2 cargo build ...
It has no point, as default x86 and x86-64 targets already enable sse2 unconditionally, so the fallback kernel is equivalent to the sse2 configuration, with the small difference of enforced alignment, but it shouldn't be a difference in practice.
Keep only fma,avx2; most x86-64 that have fma in practice also have avx2, the extra instantiation of a kernel for just fma is unnecessary code. Do this even if for a fact "avx2" is used only in the packing function and only "fma" in the microkernel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on the MSRV update, just for the update to
const fnparsing of MMTEST_FEATURE, testing-only functionality for assigning which target features to allow.MMTEST_FEATURE=avx,fma,avx2is now allowed: multiple features, separated by comma.