Delete unused sanity_test() function#191
Open
phiwuu wants to merge 1 commit into
Open
Conversation
phiwuu
force-pushed
the
internal/delete-sanity-test
branch
2 times, most recently
from
9e8de56 to
1695a42
Compare
phiwuu
changed the title
Lexer.sanity_test() functionsanity_test() function
phiwuu
added
the
internal
The function existed in `lexer.py` for legacy reasons and was introduced at a time when no tests existed. It can now be deleted.
phiwuu
force-pushed
the
internal/delete-sanity-test
branch
from
1695a42 to
279342b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function existed in
lexer.pyfor legacy reasons and was introduced at a time when no tests existed.It can now be deleted.