Skip to content

chore(rules): enforce exhaustive CLI+MCP E2E tests and CI merge gate #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bntvllnt merged 1 commit into from
Jun 3, 2026
Merged

chore(rules): enforce exhaustive CLI+MCP E2E tests and CI merge gate #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ npm run test # vitest

All four must pass before shipping. Run in order: lint -> typecheck -> build -> test.

**CI is the merge gate (BLOCKING).** The full pipeline (lint → typecheck → build → test incl. E2E → coverage) runs in `.github/workflows/ci.yml`. Red CI blocks merge. Never suppress to pass a gate — no `eslint-disable`, no `@ts-ignore`/`@ts-expect-error`, no skipped tests. Fix the cause.

## Release Protocol

### Version Bumping
Expand Down Expand Up @@ -161,6 +163,7 @@ LLM knowledge base for building this tool. Single source of truth per topic:
- Every bug fix MUST include a regression test
- Target: maximum coverage — if code exists, it should be tested
- No feature or fix ships without corresponding tests
- Every CLI command, flag, MCP tool, and metric maps to at least one E2E scenario — a surface with no E2E is an incomplete feature (BLOCKING)

### Real Environment Tests (MANDATORY)

Expand All @@ -178,7 +181,14 @@ LLM knowledge base for building this tool. Single source of truth per topic:
| Graph | Real parsed files -> real graph builder, assert nodes/edges |
| Analyzer | Real graph -> real metrics, assert values |
| MCP | Real MCP server instance, assert tool responses |
| CLI | Real process execution where feasible |
| CLI | Real process execution — spawn built binary, assert stdout/stderr/exit + side-effects |

### E2E (CLI + MCP) — BLOCKING

- Every CLI command and every MCP tool MUST have an E2E test that exercises the REAL surface — spawn the built binary (`node dist/cli.js …` / `npx codebase-intelligence …`) or a real MCP stdio server — and asserts real output, exit code, and any files/side-effects. No internal mocks (see Anti-Patterns).
- Full lifecycle for stateful commands: e.g. `init` asserts the files it writes, idempotency (re-run is safe), and `--json` shape — not just exit 0.
- New command, new flag, or new MCP tool = new or updated E2E test in the same change. A behavior change with no E2E update fails the gate.
- "E2E" here means CLI/MCP real-process tests. Browser E2E (Playwright/Maestro) does NOT apply — this package has no UI. This project rule overrides the global ui-testing rule.

### Anti-Patterns (NEVER)

Expand Down
Loading