refactor: make Trace an unsafe trait for boa_engine compatibility#93
Open
shruti2522 wants to merge 1 commit into
Open
refactor: make Trace an unsafe trait for boa_engine compatibility#93shruti2522 wants to merge 1 commit into
shruti2522 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated the
Tracetrait in bothnull_collector_brandedandmark_sweep_brandedto be anunsafetrait so we canintegrate it into
boa_enginemy initial thought was to keep it a safe trait, but doing so broke the engine's closure type inference.
Tracemust be anunsafetrait, because if an implementor forgets to trace a GC pointer, it causes a UAF bug that the compiler can't catch.I also changed the method signature from
trace(&mut self)totrace(&self). This is necessary because gc objects frequently form reference cycles.fn trace(&mut self)tounsafe fn trace(&self)impl Traceblocks tounsafe impl Trace?Sizedtypes, added anas_ptr()helper toGcthis ensures
oscarsis compatible withboa_engine, allowing to drop it in as a backend without changing any core engine code