chore(docs): add lld mention for macOS to BUILD.md#102
Open
tbeseda wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
BUILD.mddoes not mention thelldrequirement for macOS. Following the instructions meansmakefails even though theclangsmoke test passes.lldis needed.I couldn't find an existing issue. If you'd rather author your own changes to BUILD.md, feel free to close this - I just wanted to make a quick fix to a small issue available.
Type of change
Checklist
These seem generic to other bombshell projects and don't apply here (
deno testdoes pass).pnpm test)pnpm format)AI-generated code disclosure
Opus 4.8 helped update the smoke test to also link and more closely match the commands used in
maketo catch other missing dependencies.