Skip to content

Performance optimization for or_parser #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
andreasbuhr wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Performance optimization for or_parser #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions include/boost/parser/parser.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3396,7 +3396,6 @@ namespace boost { namespace parser {
template<typename Parser>
auto operator()(Parser const & parser) const
{
detail::skip(first_, last_, skip_, flags_);
success_ = true; // In case someone earlier already failed...
return parser.call(
first_,
Expand All @@ -3410,7 +3409,6 @@ namespace boost { namespace parser {
template<typename Parser, typename Attribute>
void operator()(Parser const & parser, Attribute & retval) const
{
detail::skip(first_, last_, skip_, flags_);
success_ = true; // In case someone earlier already failed...

detail::apply_parser(
Expand Down Expand Up @@ -3518,6 +3516,7 @@ namespace boost { namespace parser {
*this, first, last, context, flags, retval);
#endif

auto unmodified_first = first;
use_parser_t<Iter, Sentinel, Context, SkipParser> const use_parser{
first, last, context, skip, flags, success};

Expand All @@ -3539,12 +3538,16 @@ namespace boost { namespace parser {
else
use_parser.first_ = prev_first;
};
detail::skip(first, last, skip, flags);

std::apply([&try_parser](auto&&... args) {
((try_parser(args)), ...);
}, parsers_);

if (!done)
if (!done) {
success = false;
first = unmodified_first;
}
}

#ifndef BOOST_PARSER_DOXYGEN
Expand Down
Loading