integration-tests: use itest::TestResult instead of color_eyre#238
Merged
gursewak1997 merged 1 commit intomainfrom Mar 31, 2026
Merged
integration-tests: use itest::TestResult instead of color_eyre#238gursewak1997 merged 1 commit intomainfrom
gursewak1997 merged 1 commit intomainfrom
Conversation
Signed-off-by: gursewak1997 <gursmangat@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
cgwalters
approved these changes
Mar 31, 2026
Collaborator
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Oh I think this was a classic semantic merge conflict problem that we'd fix by going to merge queues bootc-dev/infra#143
In this case the merge queue would have failed both PRs together, and I think would have enabled us to drop one of them out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build error introduced in #232 where
run_ephemeral_ignition.rsusedcolor_eyre::Resultinstead ofitest::TestResult. The file was added without the required dependency and didn't follow the existing convention used by other test files in the crate.To be fair, this should have been caught in the PR build runs but no idea why it wasn't; probably some caching issue.