Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to remove kernel arguments during installation via a new --karg-delete CLI option and a corresponding karg-deletes field in the installation configuration. The implementation includes logic to process these deletions before applying new arguments, a helper function for precise or key-based removal, and comprehensive unit and integration tests to verify the functionality. I have no feedback to provide.
Author
|
I wasn't sure about a few things when implementing this.
|
8f99e8e to
22c5fa8
Compare
This adds `--karg-delete` to install. In some relatively rare use cases, one might want to remove a kernel argument shipped in the container image. Fixes: bootc-dev#1229 Signed-off-by: Terence Lee <hone02@gmail.com>
22c5fa8 to
8cb46ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from the contribfest session. This adds
--karg-deleteto install.In some relatively rare use cases, one might want to remove a kernel argument shipped in the container image.
Fixes: #1229