Remove using enum statements for C++17 compatibility#3338
Closed
Steven-Roberts wants to merge 1 commit intoboutproject:nextfrom
Closed
Remove using enum statements for C++17 compatibility#3338Steven-Roberts wants to merge 1 commit intoboutproject:nextfrom
Steven-Roberts wants to merge 1 commit intoboutproject:nextfrom
Conversation
Contributor
|
Hi @Steven-Roberts ! Do you need to use an old compiler? The C++ version is set to C++20 in CMakeLists: https://github.com/boutproject/BOUT-dev/blob/next/CMakeLists.txt#L533 |
Contributor
Author
|
No, I can use a newer one. The README says C++17 can be used, though Line 65 in 8ab4552 |
Contributor
Ah sorry! We should fix the README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using enumstatements require C++20, so I was getting compilation errors with an old compiler.