migrate away from the fork of foliojs packages#2493
migrate away from the fork of foliojs packages#2493AnthonyLenglet wants to merge 1 commit intobpampuch:masterfrom AnthonyLenglet:feature/folio-fork-migration
Conversation
|
Contributing guide is available here: CONTRIBUTING.md |
|
removed the build folder from the PR ! |
|
CONTRIBUTING.md: |
|
is lint changes removed in the meantime though ! |
|
eslint does not make any changes in code. This changed your IDE. Back to the topic... I don't know if it will be that simple, because in PR foliojs/pdfkit#1367 for new fonkit version require changes in pdfkit. |
|
Can this PR be merged ? We are blocked due to this. |
|
Explained in my previous post. |
|
@AnthonyLenglet Could you please Merge? This is also a blocker for my project as it addresses a critical vulnerability in crypto-js dependency |
|
I do not have the ability to merge unfortunately, this has been a blocker to me as well, so I ended up moving to librairies that didn't have this package as a dependency instead in the meantime |
|
AnthonyLenglet: Which alternate library did you move to that doesn't have this package as dependency ? |
I'd have to get back to the project that was affected by this, but our problem came from compodoc, that used this library though this library has been updated a few hours ago as of writing, which I'd have to test, but it could be a fix Edit: pdfmake got updated, but linebreak is still the problematic version, I guess you might be able to install this branch specifically ? not sure |
|
Moved by commit 5926fc9. |
Closes #2492
npm run testandnpm run buildboth worked, it looks like some linter changes also made their way into the PR, hopefully that's still fine