[2.x] Build curl from the official release tarball#340
Open
GrahamCampbell wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curl build currently downloads GitHub's auto-generated git archive tarball, which is a raw snapshot of the tagged tree: its curlver.h still carries the -DEV suffix, so every layer ships a libcurl that reports itself as, for example, 8.15.0-DEV instead of 8.15.0, and the tree needs buildconf to generate configure before building. This switches the download to the official release tarball that the curl maintainers publish as a GitHub release asset, which has the version properly stamped and ships a pre-generated configure script, so the buildconf step is dropped and the built libcurl reports the true release version. This matters because Guzzle compares the curl version using
version_compare.