fix: move hardcoded DB credentials and Flask secret key to environment variables#31
Merged
Merged
Conversation
Owner
|
Tested locally, reviewed implementation, LGTM. |
brick-24
approved these changes
Jun 20, 2026
brick-24
left a comment
Owner
There was a problem hiding this comment.
LGTM, added .env to .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Database credentials and Flask secret key were hardcoded in source files:
src/config.pysrc/app.pyHardcoded credentials are a security risk — anyone who clones the repo sees them, and they get committed to git history. This is especially problematic when deploying to cloud environments (Railway, Render, AWS, etc.).
Fix
src/config.py: LoadMYSQL_HOST,MYSQL_USER,MYSQL_PASSWORDfrom environment usingpython-dotenvsrc/app.py: LoadFLASK_SECRET_KEYfrom environment.env.example: Added template so contributors know which variables to setUsage after this fix
cp .env.example .env # Fill in your values in .env pip install python-dotenv python src/app.pyReferences