Integrate brightdigit.com vendored changes + Swift 6.4 CI#9
Open
leogdion wants to merge 10 commits into
Open
Conversation
… ci] Apply the issue #54 config migration to the vendored BrightDigit libraries (SyndiKit, TransistorPublishPlugin, Contribute, ContributeWordPress, NPMPublishPlugin, YoutubePublishPlugin) using the MistKit/SundialKit library config variant: - .swiftlint.yml: strict library ruleset + no_unchecked_sendable custom rule - .swiftformat -> .swift-format: Apple swift-format JSON - .mise.toml: swift-format 604 (Swift 6.4-aligned), swiftlint, periphery - Scripts/lint.sh (mise-based, replaces Mint) + Scripts/header.sh - CI workflow -> brightdigit/swift-build@v1 (ubuntu + macos) + STRICT lint job - Remove obsolete .hound.yml Configs + CI only; source reformatting/headers deferred (matches main repo). SwiftTube and Spinetail skipped (slated for OpenAPI-generator migration). Committed in the monorepo only; no git subrepo push performed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a `test-packages` matrix job to main.yaml that builds, tests, and lints the 6 vendored BrightDigit packages in-place. In the monorepo checkout every sibling already sits at its relative-path location, so each package resolves with zero dependency reconstruction — replacing the per-package setup-deps CI. - detect-changes: add `packages` paths-filter + `packages-changed` output - remove standalone workflows + orphaned setup-deps from the 4 rel-dep packages (ContributeWordPress, Transistor, NPM, Youtube); their standalone CI was synthetic (relative deps are committed) - keep SyndiKit + Contribute standalone CIs (genuinely standalone libraries) - bump all GitHub Actions to latest: checkout v6, cache v5, upload-artifact v7, download-artifact v8, dorny/paths-filter v4 (swift-build@v1 unchanged) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…packages Brings Contribute, NPMPublishPlugin, ContributeWordPress, and YoutubePublishPlugin to a clean `swiftlint --strict` pass (the failing matrix Lint legs). Applies the same issue #54 treatment as the main repo: swift-format formatting + MIT license headers (Scripts/header.sh) + source fixes. SyndiKit intentionally left for a separate pass. Source fixes (no config changes; public API and behavior preserved): - generic_type_name: shorten generic parameter names to <=20 chars - type_contents_order / file_types_order: reorder type members - explicit_acl / explicit_top_level_acl: add explicit access modifiers - one_declaration_per_file: split secondary declarations into new files - missing_docs: add doc comments to public declarations (Youtube) - force_try: replace try! with do/catch - superfluous/blanket_disable_command: remove stale / narrow to scoped disables - xct_specific_matcher, first_where, identifier_name, line_length, multiline_arguments_brackets, empty_xctest_method, orphaned_doc_comment Verified per package: swiftlint --strict = 0, swift build --build-tests, and swift test all pass; CI-mode Scripts/lint.sh exits "Linting completed successfully". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Restore Linux coverage under Swift 6.4 via patched coverage action (#92) Swift 6.4's swiftbuild engine emits Linux test bundles as <Name>.so under .build/out/Products/<config>-linux-<arch>/ (no .xctest), which sersoft-gmbh/swift-coverage-action@v5 couldn't pair with the profdata, so Linux coverage was silently dropped. Point the Ubuntu coverage step at the brightdigit fork (pinned by SHA) that detects the .so test bundle, and re-enable fail-on-empty-output so a future regression is fatal again. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Add coverage for NPMPublishPlugin/ButtondownKit; ignore generated files Raise patch coverage for first-party code changed in the Phase 4 OpenAPI migration (#109). - NPMPublishPlugin: add pure-logic XCTest suites for the restructured NPM/ types whose tests were dropped (URL.relativePath, NPM.Argument, the Argument/Job result builders, Command, Settings, Job + ci()/run(), NPMInvocationError), and expand NPMInvocation factory coverage. - ButtondownKit: cover ButtondownClient sendDraft/email error paths and init(apiKey:) via the existing MockTransport. - codecov: ignore OpenAPI-generated files (**/Generated/**) in the root config and add per-package configs for ButtondownKit and SwiftTube. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Fix Contribute lint.sh errors - Repin .swift-version to 6.4.x-snapshot (5.8 toolchain not installed) - Force native build system for periphery so it finds the index store (Swift 6.4's swiftbuild writes it to .build/index-build/...) - Use .isEmpty over == "" (SwiftLint empty_string) - Drop redundant try? on Result<Bool, Never>.get() in FileManagerSpy - Remove unused enum/property flagged by periphery - Verify closure invocation via return value instead of mutating a captured var from a @sendable closure Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ed copy Replaces the relative-path dependency on the in-repo vendored SwiftSoup (Packages/scinfu/SwiftSoup) with the published brightdigit/SwiftSoup fork (branch fix/swift-6.4-inline-crash = upstream f474b11 + the @inline patch). Removes the 144-file vendored tree. Contribute now has no path dependencies and builds standalone (verified: debug + release build on Swift 6.4). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the brightdigit.com monorepo-vendored copy of this package back to its standalone repository, and brings CI in line with the BrightDigit Swift 6.4 template where applicable.
🤖 Generated with Claude Code