[STG-2002] feat: migrate Convex Stagehand package#73
Open
shrey150 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@browserbasehq/convex-stagehandintopackages/convex-stagehandpackages/*to the pnpm workspace and root Changesets release scripts/config0.1.0viteas a direct dev dependency because the exported./testhelper referencesvite/client; npm flattened this transitively in the standalone repo, but pnpm release installs require it directlyLinear: https://linear.app/browserbase/issue/STG-2002/migrate-convex-stagehand-package-into-integrations
Release CI / npm publishing
This PR preserves the publishing path in-repo, but npm Trusted Publishing needs to be moved from
browserbase/convex-stagehandto this repo before the publish job can succeed:@browserbasehq/convex-stagehandTrusted Publisher to use repositorybrowserbase/integrations.release.yml(the file lives at.github/workflows/release.yml).Without that npm-side Trusted Publisher update,
changeset publishshould be able to create release PRs but the actual npm publish step is expected to fail authorization.Validation
pnpm install --no-frozen-lockfilepnpm run build:packagespnpm --dir packages/convex-stagehand run lint(passes with generated-file warnings)npm pack --dry-runinpackages/convex-stagehandpnpm exec changeset status --verboseshows@browserbasehq/convex-stagehand->0.1.1Notes:
pnpm --dir packages/convex-stagehand run testfails the same way the standalone repo currently fails: Vitest reports missing@edge-runtime/vmand exits because no test files are present.pnpm run lintcurrently fails before reaching this package becauseexamples/integrations/vercel/vercel-puppeteer/eslint.config.mjsimports@eslint/eslintrc, which is not a root dependency.