Rework approval bypass notifier to work on push events#30
Merged
Conversation
DMarby
approved these changes
Jul 6, 2026
Member
There was a problem hiding this comment.
Looks fine functionally, since this assumes the push event, we'll need to update the the workflow that calls this across every single repo at the same time as merging this I guess (as they currently use the pull_request event?
May be nice to have this workflow detect and handle both, that way we can take our time rolling that change out, but just swapping them all over is fine at once also.
Contributor
Author
|
Thanks @DMarby great point - I forgot not all callers will be pinning the workflow hash, transparently breaking seems bad. I have added support for old and new - nothing fancy, just literally copies the old flow back in as a different job and one or the other is selected by |
DMarby
approved these changes
Jul 7, 2026
DMarby
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the workflow is designed to run on pull request events and requires a Slack webhook secret. Unfortunately, PRs from forks can't see the secret so this workflow always fails for them. I tend to use forks for development of owned repositories to confirm external contributor experience and noticed this. To clarify, this only results in workflow failure for the person that merges a PR (like me), not the external contributor themselves so is not as bad as it could be.
But it's not that hard to rework to fetch the PR for a merged commit, then the problem goes away and all PRs, even external, get validated.