Add Python license-header package#37
Merged
Merged
Conversation
Co-authored-by: Timo Stamm <ts@timostamm.de>
ajeetdsouza
approved these changes
Jul 3, 2026
| if fnmatch.fnmatch(filepath, pattern): | ||
| return True | ||
| # Expand ** to match any number of path segments | ||
| if pattern.startswith("**/"): |
There was a problem hiding this comment.
We shouldn't be doing this manually - PurePath.full_match() handles everything we need and is part of the stdlib. We will have to upgrade our Python target to 3.13 though.
Contributor
Author
There was a problem hiding this comment.
As this is the code were already using, I'm ok with it for now. Things get awkward if we raise the Python target since downstream repos don't target such a recent Python, and if some dev tasks work on certain python but not others it can get confusing. An unnecessary concern since we have this working implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reuse in our Python projects. Originally written by @timostamm
It's kept to the bare minimum for being a simple tool, no tagged releases just pushing to pypi from main. Duplicate version numbers are automatically skipped by pypi. Will get the environment setup before merging.