refactor: remove testify and transitive dependencies#216
Merged
Conversation
cmaglie
pushed a commit
that referenced
this pull request
May 25, 2026
The Go directive in go.mod specifies the minimum Golang version required to run the library. Update #216 bumped this version to 1.26, making impossible to run the library with an older one. I propose to mimic the behavior of official Golang libraries and support the last 2 major Go versions, which are the ones that are receiving security updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, go-serial has the following dependencies:
If #149 is merged,
goselectwill disappear.The project only uses a couple of functions from
testifywhich are easy to refactor out to remove the other dependencies, leaving justgolang.org/x/sysas a dependency, which would reduce the supply chain attack surface of the project.