[harmony] Bug 2051802: Abort UTF8 conversion without an explicit override - #177
Open
justdave wants to merge 1 commit into
Open
[harmony] Bug 2051802: Abort UTF8 conversion without an explicit override#177justdave wants to merge 1 commit into
justdave wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When Docker hits the non-interactive UTF-8 conversion bailout, console output now prints a clear hint showing how to proceed explicitly:
BZ_ALLOW_UNSAFE_UTF8_CONVERSION=1 docker compose up
What changed
Net effect
Additional info
Test Plan
docker compose updocker compose downdocker compose upand verified that the conversion bailed with the new messaging.ALLOW_UNSAFE_UTF8_CONVERSION=1 docker compose upand verified that the conversion proceeded.