Skip to content

Test sql review #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shohjaxonabdurashidov wants to merge 4 commits into from
Closed

Test sql review #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee315c7
Update Bytebase configuration in release workflow
shohjaxonabdurashidov Aug 20, 2026
030bb8a
Modify SQL review action environment variables
shohjaxonabdurashidov Aug 20, 2026
430bb17
Create table t1 with id and name columns
shohjaxonabdurashidov Aug 20, 2026
a017acd
Create table t1 with id and name columns
shohjaxonabdurashidov Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/release-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ on:
- "migrations-semver/*.sql"

env:
BYTEBASE_URL: https://demo.bytebase.com
BYTEBASE_SERVICE_ACCOUNT: api@service.bytebase.com # set service account via environment variable
BYTEBASE_SERVICE_ACCOUNT_SECRET: ${{ secrets.BYTEBASE_SERVICE_ACCOUNT_SECRET }} # set service account secret via environment variable
BYTEBASE_PROJECT: "projects/hr"
BYTEBASE_URL: https://maximum-condor-friendly.ngrok-free.app
BYTEBASE_SERVICE_ACCOUNT: api-sample@service.bytebase.com # set service account via environment variable
BYTEBASE_SERVICE_ACCOUNT_SECRET: bbs_Q9R2l9Gw0ZcNkqigMn0B # set service account secret via environment variable
BYTEBASE_PROJECT: "projects/test-project-gsug"

jobs:
build:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/sql-review-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ jobs:
uses: actions/checkout@v4
- name: Check release
env:
BYTEBASE_URL: https://maximum-condor-friendly.ngrok-free.app
BYTEBASE_SERVICE_ACCOUNT: api-sample@service.bytebase.com # set service account via environment variable
BYTEBASE_SERVICE_ACCOUNT_SECRET: bbs_Q9R2l9Gw0ZcNkqigMn0B # set service account secret via environment variable
BYTEBASE_PROJECT: "projects/test-project-gsug"
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # set GITHUB_TOKEN because the 'Check release' step needs it to comment the pull request with check results.
BYTEBASE_URL: https://demo.bytebase.com
BYTEBASE_SERVICE_ACCOUNT: api@service.bytebase.com # set service account via environment variable
BYTEBASE_SERVICE_ACCOUNT_SECRET: ${{ secrets.BYTEBASE_SERVICE_ACCOUNT_SECRET }} # set service account secret via environment variable
BYTEBASE_PROJECT: "projects/hr"
BYTEBASE_TARGETS: "instances/prod-sample-instance/databases/hr_prod"
FILE_PATTERN: "migrations-semver/*.sql"
run: |
Expand Down
4 changes: 4 additions & 0 deletions migrations-semver/202503131500_create_table_t1_ddl.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
CREATE TABLE t1 (
id SERIAL PRIMARY KEY,
name TEXT
);
4 changes: 4 additions & 0 deletions migrations/202603131500_create_table_t1_ddl.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
CREATE TABLE t1 (
id SERIAL PRIMARY KEY,
name TEXT
);