fix(url): validate name in URLSearchParams.append()#320
Merged
andreiltd merged 1 commit intoJul 20, 2026
Merged
Conversation
Member
|
@watilde could you resolve conflicts? It is good to go otherwise. |
URLSearchParams.append() never checked whether stringifying the name argument succeeded. For a non-stringifiable name (a Symbol, or an object whose toString throws), core::encode_spec_string returns a SpecString with a null data pointer and a pending exception, which append handed straight to the Rust params_append — crashing the process in slice::from_raw_parts (UB in release) instead of throwing. Null-check the encoded name and propagate the pending exception, exactly as delete()/has()/get()/set() already do. Add an integration test. Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
watilde
force-pushed
the
fix/urlsearchparams-append-name-validation
branch
from
July 20, 2026 13:53
761ed9e to
03a161d
Compare
Contributor
Author
|
@andreiltd Thanks for reviewing. Rebased onto main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URLSearchParams.append() never checked whether stringifying the name argument succeeded. For a non-stringifiable name (a Symbol, or an object whose toString throws), core::encode_spec_string returns a SpecString with a null data pointer and a pending exception, which append handed straight to the Rust params_append — crashing the process in slice::from_raw_parts (UB in release) instead of throwing.
Null-check the encoded name and propagate the pending exception, exactly as delete()/has()/get()/set() already do. Add an integration test.