feat: Add fs::ioctl_ficlonerange for FICLONERANGE#1624
Open
pauldoo wants to merge 1 commit into
Open
Conversation
Alongside `fs::ioctl_ficlone` for FICLONE, add support for the FICLONERANGE operation.
Author
|
I believe the test failures are unrelated to my changes. They are being tracked here: #1607 |
Author
|
It seems to be rustix convention that all these functions are marked But it's it's not clear to me why this is done.... I doubt it's for performance reasons. All of these functions are wrappers to system calls, and the cost of any system call will dwarf the saving from inlining. I'd like to hear the opinion of rustix maintainers on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alongside
fs::ioctl_ficlonefor FICLONE, add support for the FICLONERANGE operation.I have tested this on a local
btrfsfilesystem and I believe XFS with reflinks should support this too.The existing
ioctl_ficloneclaimed that SPARC is not supported. I don't have a SPARC system to test on, but I'm assuming that if whole file cloning (reflinking) isn't supported on SPARC, then neither too would range cloning.