Skip to content

update bumpalo#2513

Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom
maksimryndin:update-bumpalo
May 6, 2026
Merged

update bumpalo#2513
alexcrichton merged 1 commit intobytecodealliance:mainfrom
maksimryndin:update-bumpalo

Conversation

@maksimryndin
Copy link
Copy Markdown
Contributor

@maksimryndin maksimryndin commented May 6, 2026

Hey guys!

Thanks a lot for your tremendous work over wasm rust tooling!

A small PR to update bumpalo as the old version causes version conflicts (https://github.com/bytecodealliance/wasmtime/blob/main/Cargo.toml#L374)

@maksimryndin maksimryndin requested a review from a team as a code owner May 6, 2026 13:39
@maksimryndin maksimryndin requested review from fitzgen and removed request for a team May 6, 2026 13:39
Copy link
Copy Markdown
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Although FWIW this shouldn't be necessary because the version requirement here is "3.x.x, minimum 3.14.0", which is compatible with Wasmtime's requirement of 3.20. Out of curiosity, how did the conflict arise?

Nevertheless this is still fine to merge, so I'll flag it as such here.

@alexcrichton alexcrichton added this pull request to the merge queue May 6, 2026
Merged via the queue into bytecodealliance:main with commit 6c57bdc May 6, 2026
37 checks passed
@maksimryndin
Copy link
Copy Markdown
Contributor Author

maksimryndin commented May 6, 2026

Thanks! Although FWIW this shouldn't be necessary because the version requirement here is "3.x.x, minimum 3.14.0", which is compatible with Wasmtime's requirement of 3.20. Out of curiosity, how did the conflict arise?

Nevertheless this is still fine to merge, so I'll flag it as such here.

Hey @alexcrichton! ✋ I am upgrading dependencies in the project NethermindEth/stellar-private-payments#191 and there was a conflict with the latest wast (https://github.com/NethermindEth/stellar-private-payments/blob/feature-protocol-26/circuits/build.rs#L874). But you're absolutely right - just updating it in Cargo.lock solved the issue.

Thanks a lot for a quick feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants