Skip to content

addr2line: echo input addresses back as given instead of hex#2521

Merged
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
eyupcanakman:fix/addr2line-input-radix
May 17, 2026
Merged

addr2line: echo input addresses back as given instead of hex#2521
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
eyupcanakman:fix/addr2line-input-radix

Conversation

@eyupcanakman
Copy link
Copy Markdown
Contributor

addr2line parsed each address into a u64 and used that same binding for the printed label, so a decimal input like 255 came back as 0xff. Keep the original input string for the label and only feed the parsed value into the lookup. Hex input is unchanged. Updated the help-text example and added a cli test.

Closes #2328

@eyupcanakman eyupcanakman requested a review from a team as a code owner May 16, 2026 20:06
@eyupcanakman eyupcanakman requested review from fitzgen and removed request for a team May 16, 2026 20:06
Copy link
Copy Markdown
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue May 17, 2026
Merged via the queue into bytecodealliance:main with commit 3b45554 May 17, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

addr2line prints addresses in hex if given in decimal

2 participants