wit-parser: don't panic on a re-exported imported resource#2526
Merged
pchickey merged 1 commit intoMay 22, 2026
Merged
Conversation
`validate` accepts a component that imports a resource-bearing instance and re-exports it under a new name, but `component wit` panicked on an `assert!` while decoding it. WIT can't represent a re-exported imported resource. Return a structured error instead of panicking, and add a cli test for the panic plus one for the same import without the re-export, which still decodes. Closes bytecodealliance#2506
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateaccepts a component that imports a resource-bearing instance and re-exports it under a new name, butcomponent witpanicked on anassert!while decoding it. WIT can't represent a re-exported imported resource. Return a structured error instead of panicking, and add a cli test for the panic plus one for the same import without the re-export, which still decodes.Closes #2506