aarch64: Implement scalar ueq and one comparisons#13324
Open
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Open
aarch64: Implement scalar ueq and one comparisons#13324alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
ueq and one comparisons#13324alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
This fills out an `unimplemented!()` block in the aarch64 backed for the `UnorderedOrEqual` and `OrderedNotEqual` float comparisons. These aren't reachable from WebAssembly and are not as trivial as other orderings to implement, but with the refactoring in bytecodealliance#13315 the implementation isn't too hairy. The lowerings are sub-optimal for `brif`, `trapnz*` and `select` but they should at least work now. Notes are left for where the lowerings can be improved, and disassembly/runtests were added for many pieces here.
github-actions
Bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fills out an
unimplemented!()block in the aarch64 backed for theUnorderedOrEqualandOrderedNotEqualfloat comparisons. These aren't reachable from WebAssembly and are not as trivial as other orderings to implement, but with the refactoring in #13315 the implementation isn't too hairy. The lowerings are sub-optimal forbrif,trapnz*andselectbut they should at least work now. Notes are left for where the lowerings can be improved, and disassembly/runtests were added for many pieces here.