Fix usage of GC barriers when throwing an exnref #13330
Open
alexcrichton wants to merge 3 commits intobytecodealliance:mainfrom
Open
Fix usage of GC barriers when throwing an exnref #13330alexcrichton wants to merge 3 commits intobytecodealliance:mainfrom
alexcrichton wants to merge 3 commits intobytecodealliance:mainfrom
Conversation
Keeps imports a bit more organized and additionally cuts down on the quantity of #[cfg] needed.
* `set_pending_exception` didn't have a write barrier to handle any previously configured exception. * When an `exnref` was caught it didn't go through `expose_gc_ref_to_wasm`. * During `throw_impl` the `exnref` wasn't cloned to give a strong reference to the store. All of these should now be fixed with some minor refactorings and such to ensure we've got the right barriers in the right places. Closes bytecodealliance#13316
github-actions
Bot
added
wasmtime:api
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_pending_exceptiondidn't have a write barrier to handle anypreviously configured exception.
exnrefwas caught it didn't go throughexpose_gc_ref_to_wasm.throw_impltheexnrefwasn't cloned to give a strongreference to the store.
All of these should now be fixed with some minor refactorings and such
to ensure we've got the right barriers in the right places.
Closes #13316